Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check if path_gdx_bau is correctly set (NA for no NDC run, not NA for NDC) #1370

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Aug 2, 2023

Purpose of this PR

  • Fixes a bug introduced by Check if input_bau.gdx is given or really needed; a couple of minor changes mostly related to MAgPIE coupling #1366
  • In scenario_config.csv, the SSP5-PkBudg500 scenario had path_gdx_bau set to SSP5-NPi but did not have carbonprice or carbonpriceRegi to NDC. So the check @dklein-pik introduced set path_gdx_bau to NA, which is correct.
  • But: as this was done once the cfg list was obtained, the SSP5-NPi run still thought SSP5-PkBudg500 had him as a dependency, and therefore started it again (happened in the AMT runs):
  • This PR fixes this error twofold:
    • First, I add the check and fix earlier, in readCheckScenarioConfig to make sure all runs know about the changed dependencies
    • Second, while starting subsequent runs, the script now checks whether the gdx is actually still needed, and if not, skips the run to avoid starting it multiple times.
  • I kept the check that @dklein-pik added in checkFixCfg. First, redundancy is not bad ;). Second, I think we still need that because you could still reintroduce such a wrong dependency by having path_gdx_bau set in scenario_config_coupled.csv, but as readCheckScenarioConfig cannot know what value carbonprice has in scenario_config.csv (so without coupled), we have no way to avoid that except at this later stage (which is why David and myself agreed to put it there in the first place).

Type of change

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • All automated model tests pass (FAIL 0 in the output of make test)
  • All automated coupled model tests pass (FAIL 0 in the output of make test-coupled-slurm)
  • I did not update the changelog

for the record: AMT runs that were started twice:

SSP5-PkBudg500-AMT_2023-07-29_01.57.52     7.8 hours    55/100   converged
SSP5-PkBudg500-AMT_2023-07-29_00.46.54     7.7 hours    54/100   converged
SSP5-PkBudg1150-AMT_2023-07-29_01.58.01    7.2 hours    52/100   converged
SSP5-PkBudg1150-AMT_2023-07-29_00.47.02    7.6 hours    61/100   converged
SSP1-PkBudg500-AMT_2023-07-29_00.59.39     5.6 hours    46/100   converged
SSP1-PkBudg500-AMT_2023-07-29_00.46.39     5.6 hours    46/100   converged
SSP1-PkBudg1150-AMT_2023-07-29_00.59.47    4 hours      32/100   converged
SSP1-PkBudg1150-AMT_2023-07-29_00.46.46    4 hours      32/100   converged

@orichters orichters changed the title Fix bau checker Fix check if path_gdx_bau is correctly set (NA for no NDC run, not NA for NDC) Aug 2, 2023
@orichters orichters merged commit 4d7ae0e into remindmodel:develop Aug 2, 2023
1 check passed
@orichters orichters deleted the fix_bau_checker branch December 6, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants